Skip to content

fix(search): prevent-local-sync-state-keystroke-loss#7287

Merged
Zaimwa9 merged 1 commit intomainfrom
fix/search-missing-keystrokes
Apr 20, 2026
Merged

fix(search): prevent-local-sync-state-keystroke-loss#7287
Zaimwa9 merged 1 commit intomainfrom
fix/search-missing-keystrokes

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 19, 2026 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Closes #7199

Changes

  • Drop the value → localValue sync effect in TableSearchFilter that was overwriting in-progress input (root cause of the keystroke eating).
  • Add a searchResetKey from useFeatureFilters so "Clear Filters" remounts the input.
  • Rewrite useDebounce with a useRef timer to avoid re-render churn and stale closures.

How did you test this code?

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 19, 2026 09:48
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team April 19, 2026 09:48
claude[bot]
claude bot reviewed Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 19, 2026 9:48am
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 19, 2026 9:48am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 19, 2026 9:48am

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Apr 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7287 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7287 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7287 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7287 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7287 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7287 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  9.4 seconds
commit  a07e73d
info  🔄 Run: #16181 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  48.9 seconds
commit  a07e73d
info  🔄 Run: #16181 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  53 seconds
commit  a07e73d
info  🔄 Run: #16181 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 11 seconds
commit  a07e73d
info  🔄 Run: #16181 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026

Visual Regression

16 screenshots compared. See report for details.
View full report

@talissoncosta talissoncosta linked an issue Apr 20, 2026 that may be closed by this pull request
Feature search bar misses keystrokes #7199
Closed
4 tasks
talissoncosta
talissoncosta approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling it! 👏 😃

@Zaimwa9 Zaimwa9 merged commit 2be0f41 into main Apr 20, 2026
30 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/search-missing-keystrokes branch April 20, 2026 12:50
@flagsmithdev flagsmithdev mentioned this pull request Apr 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@talissoncosta talissoncosta talissoncosta approved these changes

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature search bar misses keystrokes

2 participants

@Zaimwa9 @talissoncosta